Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MongoDBLibrary with util/mongoapi #53

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Jan 18, 2024

This PR replaces MongoDBLibrary with util/mongoapi.

@gatici gatici force-pushed the TELCO-880-replace-MongoLibrary-with-util-Mongoapi branch from 2fea292 to 492e0dd Compare January 18, 2024 11:23
@gatici gatici force-pushed the TELCO-880-replace-MongoLibrary-with-util-Mongoapi branch 3 times, most recently from 8c5cf63 to 597f560 Compare January 18, 2024 15:25
service/init.go Outdated Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-880-replace-MongoLibrary-with-util-Mongoapi branch 2 times, most recently from d79b310 to 33f9f9a Compare January 19, 2024 09:50
@gatici gatici force-pushed the TELCO-880-replace-MongoLibrary-with-util-Mongoapi branch 5 times, most recently from b1b0f02 to 661efbd Compare January 30, 2024 11:38
thakurajayL
thakurajayL previously approved these changes Jan 30, 2024
@gab-arrobo
Copy link
Contributor

@gatici, have you run E2E tests using these changes?

@gab-arrobo gab-arrobo dismissed thakurajayL’s stale review January 30, 2024 20:47

There are issues with PR when running E2E test

@gab-arrobo
Copy link
Contributor

@gatici, have you run E2E tests using these changes?

@thakurajayL @gatici,

FYI, when running an E2E test using AiaB and gNBSim with the changes in this PR, I get the following errors:

2024-01-30T20:35:46Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007497, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT
2024-01-30T20:35:46Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007498, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT
2024-01-30T20:35:46Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007499, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT
2024-01-30T20:35:46Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007500, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT
2024-01-30T20:35:46Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007501, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT

@gatici gatici force-pushed the TELCO-880-replace-MongoLibrary-with-util-Mongoapi branch 8 times, most recently from 69dbbef to 9ffe945 Compare February 1, 2024 13:55
@gatici gatici force-pushed the TELCO-880-replace-MongoLibrary-with-util-Mongoapi branch 2 times, most recently from 827f72d to 0df6f5e Compare February 1, 2024 17:43
@gatici gatici force-pushed the TELCO-880-replace-MongoLibrary-with-util-Mongoapi branch from 0df6f5e to b0f671f Compare February 1, 2024 20:20
@gatici
Copy link
Contributor Author

gatici commented Feb 1, 2024

@gatici, have you run E2E tests using these changes?

@thakurajayL @gatici,

FYI, when running an E2E test using AiaB and gNBSim with the changes in this PR, I get the following errors:

2024-01-30T20:35:46Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007497, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT
2024-01-30T20:35:46Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007498, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT
2024-01-30T20:35:46Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007499, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT
2024-01-30T20:35:46Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007500, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT
2024-01-30T20:35:46Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007501, procedure:REGISTRATION-PROCEDURE, error:triggering event:REGISTRATION-REQUEST-EVENT, expected event:AUTHENTICATION-REQUEST-EVENT, received event:REGISTRATION-REJECT-EVENT

The patch is updated and tested. It passes the UE registration successfully now.
UDR log:

2024-02-01T20:24:51.154Z [udr] 2024-02-01T20:24:51Z [INFO][UDR][Init] Started KeepAlive Timer: 60 sec
2024-02-01T20:24:51.154Z [udr] 2024-02-01T20:24:51Z [INFO][UDR][CFG] Sent Register NF Instance with updated profile
2024-02-01T20:25:11.884Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][DRepo] Handle QueryAuthSubsData
2024-02-01T20:25:11.885Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][GIN] | 200 |     10.1.146.26 | GET     | /nudr-dr/v1/subscription-data/imsi-208930100007487/authentication-data/authentication-subscription |
2024-02-01T20:25:11.886Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][DRepo] Handle ModifyAuthentication
2024-02-01T20:25:11.894Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][GIN] | 204 |     10.1.146.26 | PATCH   | /nudr-dr/v1/subscription-data/imsi-208930100007487/authentication-data/authentication-subscription |
2024-02-01T20:25:11.905Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][DRepo] Handle CreateAuthenticationStatus
2024-02-01T20:25:11.916Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][GIN] | 204 |     10.1.146.26 | PUT     | /nudr-dr/v1/subscription-data/imsi-208930100007487/authentication-data/authentication-status |
2024-02-01T20:25:11.925Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][DRepo] Handle QueryAmData
2024-02-01T20:25:11.925Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][GIN] | 200 |     10.1.146.26 | GET     | /nudr-dr/v1/subscription-data/imsi-208930100007487/20893/provisioned-data/am-data?supported-features= |
2024-02-01T20:25:11.930Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][DRepo] Handle CreateAmfContext3gpp
2024-02-01T20:25:11.931Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][GIN] | 204 |     10.1.146.26 | PUT     | /nudr-dr/v1/subscription-data/imsi-208930100007487/context-data/amf-3gpp-access |
2024-02-01T20:25:11.934Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][DRepo] Handle QueryAmData
2024-02-01T20:25:11.935Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][GIN] | 200 |     10.1.146.26 | GET     | /nudr-dr/v1/subscription-data/imsi-208930100007487/20893/provisioned-data/am-data?supported-features=20893 |
2024-02-01T20:25:11.939Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][DRepo] Handle QuerySmfSelectData
2024-02-01T20:25:11.939Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][GIN] | 200 |     10.1.146.26 | GET     | /nudr-dr/v1/subscription-data/imsi-208930100007487/20893/provisioned-data/smf-selection-subscription-data?supported-features= |
2024-02-01T20:25:11.942Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][DRepo] Handle QuerySmfRegList
2024-02-01T20:25:11.942Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][GIN] | 200 |     10.1.146.26 | GET     | /nudr-dr/v1/subscription-data/imsi-208930100007487/context-data/smf-registrations?supported-features= |
2024-02-01T20:25:11.945Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][DRepo] Handle CreateSdmSubscriptions
2024-02-01T20:25:11.945Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][GIN] | 201 |     10.1.146.26 | POST    | /nudr-dr/v1/subscription-data/imsi-208930100007487/context-data/sdm-subscriptions |
2024-02-01T20:25:11.956Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][DRepo] Handle PolicyDataUesUeIdAmDataGet
2024-02-01T20:25:11.957Z [udr] 2024-02-01T20:25:11Z [INFO][UDR][GIN] | 200 |     10.1.146.63 | GET     | /nudr-dr/v1/policy-data/ues/imsi-208930100007487/am-data |
2024-02-01T20:25:12.195Z [udr] 2024-02-01T20:25:12Z [INFO][UDR][DRepo] Handle QuerySmData
2024-02-01T20:25:12.196Z [udr] 2024-02-01T20:25:12Z [INFO][UDR][GIN] | 200 |     10.1.146.26 | GET     | /nudr-dr/v1/subscription-data/imsi-208930100007487/20893/provisioned-data/sm-data?single-nssai=%7B%22sst%22%3A1%2C%22sd%22%3A%22010203%22%7D |
2024-02-01T20:25:12.201Z [udr] 2024-02-01T20:25:12Z [INFO][UDR][DRepo] Handle PolicyDataUesUeIdSmDataGet
2024-02-01T20:25:12.202Z [udr] 2024-02-01T20:25:12Z [INFO][UDR][GIN] | 200 |     10.1.146.63 | GET     | /nudr-dr/v1/policy-data/ues/imsi-208930100007487/sm-data?dnn=internet&snssai=%7B%22sst%22%3A1%2C%22sd%22%3A%22010203%22%7D |

Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (tested changes with AiaB)

@gab-arrobo gab-arrobo merged commit 1ae3a0e into omec-project:master Feb 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants